Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for secp256r1 and secp256k1 #14

Open
barretodavid opened this issue Jul 13, 2023 · 2 comments
Open

Feature Request: Add support for secp256r1 and secp256k1 #14

barretodavid opened this issue Jul 13, 2023 · 2 comments

Comments

@barretodavid
Copy link

The structure of the file account.json that describes an account contract only supports one type, open_zeppelin that relies on a single signer using the stark friendly elliptic curve found in the cairo package ecdsa.

{
  "version": 1,
  "variant": {
    "type": "open_zeppelin",
    "version": 1,
    "public_key": "<SMART_WALLET_PUBLIC_KEY>"
  },
  "deployment": {
    "status": "deployed",
    "class_hash": "<SMART_WALLET_CLASS_HASH>",
    "address": "<SMART_WALLET_ADDRESS>"
  }
}

It would be very useful to also include support for single signer using secp256k1 (Ethereum's ECC) and secp256r1 (Standard ECC). Both ECCs are already available inside the cairo repo under starknet.

@xJonathanLEI
Copy link
Owner

I think there might be a confusion regarding how accounts are handled. starkli does not directly support any specific key types. Instead, it supports whatever keys expected by the support account flavors. Right now, the only support flavor is OpenZeppelin. Additional key types will be supported once we add more "flavors" that make use of them.

@xJonathanLEI
Copy link
Owner

@barretodavid May I know which specific account contract implementations make use of these curves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants