Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

par_iter on a ReadOnlyView #136

Closed
njaard opened this issue Jan 12, 2021 · 2 comments · Fixed by #223
Closed

par_iter on a ReadOnlyView #136

njaard opened this issue Jan 12, 2021 · 2 comments · Fixed by #223
Labels
enhancement New feature or request help wanted Extra attention is needed p-medium Medium priority issue

Comments

@njaard
Copy link

njaard commented Jan 12, 2021

ReadOnlyView::iter() exists. There should be a ReadOnlyView::par_iter() too, so that it could be possible to do a for_each or collect on the items in parallel, with rayon.

@xacrimon xacrimon added enhancement New feature or request help wanted Extra attention is needed p-medium Medium priority issue labels Feb 6, 2022
@xacrimon
Copy link
Owner

xacrimon commented Feb 6, 2022

Seems useful. Marked this as needs help, I'll accept patches for this feature if I get those before I get around to this myself.

@tomkarw
Copy link
Contributor

tomkarw commented Jul 20, 2022

Hey, I implemented this, simply copying the subset of rayon functionality for DashMap and relying on shards stored in ReadOnlyVIew.map.shards.

Had to pub(self) or pub(crate) in 3 places in total, I hope that's okay, it's how standard library goes about things like that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed p-medium Medium priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants