Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Move CornerRadius to BorderElement #1814

Closed
samhouts opened this issue Feb 6, 2018 · 3 comments
Closed

Move CornerRadius to BorderElement #1814

samhouts opened this issue Feb 6, 2018 · 3 comments
Assignees
@StephaneDelcroix
Labels
a/CSS breaking Changes behavior or appearance help wanted We welcome community contributions to any issue, but these might be a good place to start! inactive Issue is older than 6 months and needs to be retested proposal-accepted t/enhancement ➕ up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!

Comments

@samhouts
Copy link
Member

samhouts commented Feb 6, 2018

Description

CornerRadius will be used for CSS. This property is now (as of #1570) shared by Button and Frame, so it can be moved to the common BorderElement class.
@samhouts samhouts mentioned this issue Feb 6, 2018
Closed
@StephaneDelcroix
Copy link
Member

StephaneDelcroix commented Apr 11, 2018 •
edited
Loading

as one of the CornerRadius is float and the other is int, this will be a breaking change.
and while we're breaking it, it shouldn't be float or int, but CornerRadius

@weitzhandler
Copy link

Related #1754.

@samhouts samhouts added proposal-open proposal-accepted breaking Changes behavior or appearance and removed proposal-open labels Feb 7, 2020
This was referenced Feb 12, 2020
Closed
Closed
Closed
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Feb 14, 2020
@jfversluis
Copy link
Member

Won't be happening for Forms anymore!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephaneDelcroix StephaneDelcroix

Labels
a/CSS breaking Changes behavior or appearance help wanted We welcome community contributions to any issue, but these might be a good place to start! inactive Issue is older than 6 months and needs to be retested proposal-accepted t/enhancement ➕ up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@StephaneDelcroix @jfversluis @weitzhandler @samhouts