Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Commit 1be322f

Browse files
Merge branch 'main' into develop
2 parents 0ab0be0 + b09161f commit 1be322f

File tree

4 files changed

+31
-29
lines changed

4 files changed

+31
-29
lines changed

samples/XCT.Sample/App.xaml

Lines changed: 28 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@
9696
<!-- Content templates -->
9797
<ControlTemplate x:Key="GalleryPageTemplate">
9898
<StackLayout Spacing="0">
99-
<CollectionView ItemsSource="{TemplateBinding BindingContext.FilteredItems}">
100-
<CollectionView.Header>
99+
<ListView ItemsSource="{TemplateBinding BindingContext.FilteredItems}" SelectionMode="None">
100+
<ListView.Header>
101101
<ContentView Padding="20,12">
102102
<Entry
103103
HeightRequest="40"
@@ -108,36 +108,38 @@
108108
Text="{TemplateBinding BindingContext.FilterValue,
109109
Mode=OneWayToSource}" />
110110
</ContentView>
111-
</CollectionView.Header>
112-
<CollectionView.Footer>
111+
</ListView.Header>
112+
<ListView.Footer>
113113
<BoxView HeightRequest="32" />
114-
</CollectionView.Footer>
115-
<CollectionView.ItemTemplate>
114+
</ListView.Footer>
115+
<ListView.ItemTemplate>
116116
<DataTemplate>
117-
<Grid Padding="20,12">
118-
<custom:PancakeView Style="{StaticResource card}">
119-
<custom:PancakeView.GestureRecognizers>
120-
<TapGestureRecognizer Command="{Binding NavigateCommand, Source={x:RelativeSource AncestorType={x:Type ContentPage}}}" CommandParameter="{Binding .}" />
121-
</custom:PancakeView.GestureRecognizers>
122-
<Grid ColumnSpacing="20">
123-
<Grid.ColumnDefinitions>
124-
<ColumnDefinition Width="12" />
125-
<ColumnDefinition Width="*" />
126-
</Grid.ColumnDefinitions>
127-
<BoxView BackgroundColor="{Binding DetailColor, Source={x:RelativeSource AncestorType={x:Type ContentPage}}}" />
128-
<StackLayout
117+
<ViewCell>
118+
<Grid Padding="20,12">
119+
<custom:PancakeView Style="{StaticResource card}">
120+
<custom:PancakeView.GestureRecognizers>
121+
<TapGestureRecognizer Command="{Binding NavigateCommand, Source={x:RelativeSource AncestorType={x:Type ContentPage}}}" CommandParameter="{Binding .}" />
122+
</custom:PancakeView.GestureRecognizers>
123+
<Grid ColumnSpacing="20">
124+
<Grid.ColumnDefinitions>
125+
<ColumnDefinition Width="12" />
126+
<ColumnDefinition Width="*" />
127+
</Grid.ColumnDefinitions>
128+
<BoxView BackgroundColor="{Binding DetailColor, Source={x:RelativeSource AncestorType={x:Type ContentPage}}}" />
129+
<StackLayout
129130
Grid.Column="1"
130131
Padding="0,24,24,24"
131132
Spacing="8">
132-
<Label Style="{StaticResource label_section_header}" Text="{Binding Title}" />
133-
<Label Text="{Binding Description}" />
134-
</StackLayout>
135-
</Grid>
136-
</custom:PancakeView>
137-
</Grid>
133+
<Label Style="{StaticResource label_section_header}" Text="{Binding Title}" />
134+
<Label Text="{Binding Description}" />
135+
</StackLayout>
136+
</Grid>
137+
</custom:PancakeView>
138+
</Grid>
139+
</ViewCell>
138140
</DataTemplate>
139-
</CollectionView.ItemTemplate>
140-
</CollectionView>
141+
</ListView.ItemTemplate>
142+
</ListView>
141143
</StackLayout>
142144
</ControlTemplate>
143145

samples/XCT.Sample/Pages/WelcomePage.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
Margin="0,32"
5858
FontSize="Small"
5959
HorizontalOptions="Center"
60-
Text="Microsoft Corporation © 2020"
60+
Text="Microsoft Corporation © 2021"
6161
VerticalOptions="End" />
6262
</StackLayout>
6363
</ScrollView>

src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/iOS/PopupRenderer.ios.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,4 +295,4 @@ public override void DidDismiss(UIPresentationController presentationController)
295295
popoverDismissedEventManager.RaiseEvent(this, presentationController, nameof(PopoverDismissed));
296296
}
297297
}
298-
}
298+
}

src/CommunityToolkit/Xamarin.CommunityToolkit/Views/TabView/TabView.shared.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ void UpdateSelectedIndex(int position, bool hasCurrentItem = false)
820820
var selectionChangedArgs = new TabSelectionChangedEventArgs()
821821
{
822822
NewPosition = newPosition,
823-
OldPosition = SelectedIndex
823+
OldPosition = oldposition
824824
};
825825

826826
OnTabSelectionChanged(selectionChangedArgs);

0 commit comments

Comments
 (0)