Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Localization files are copied to wrong place #11232

Closed
filipnavara opened this issue Apr 17, 2021 · 4 comments
Closed

[dotnet] Localization files are copied to wrong place #11232

filipnavara opened this issue Apr 17, 2021 · 4 comments
Labels
dotnet An issue or pull request related to .NET (6) dotnet-pri0 .NET 6: required for stable release
Milestone
.NET 6

Comments

@filipnavara
Copy link
Contributor

When building #11175 locally I noticed that the localization files were incorrectly copied to a directories like bin/Debug/net6.0-macos/osx-x64/monotouchtest.app/Contents/MonoBundlees instead of MonoBundle/es. There's a directory separator missing after the MonoBundle name.
@filipnavara
Copy link
Contributor Author

filipnavara commented Apr 17, 2021 •
edited
Loading

This may have been broken by #10621 which removed the last slash from _AppContentsPath.

@spouliot
Copy link
Contributor

There was an earlier fix, in the P4 bump, to add extra / where none were required before. It's likely a similar case.

@spouliot spouliot added dotnet An issue or pull request related to .NET (6) dotnet-pri0 .NET 6: required for stable release labels Apr 17, 2021
@spouliot spouliot added this to the .NET 6 milestone Apr 17, 2021
@filipnavara
Copy link
Contributor Author

Yes, it's very likely also the case of ResolvedFileToPublish, just the other ones higher in the same file. I am not sure whether it was intentional breaking change since the MSBuild documentation for MakeRelative still shows directory separators being inserted.

@spouliot spouliot mentioned this issue Apr 19, 2021
Closed
@spouliot
Copy link
Contributor

Fixed in 52ca962

@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dotnet An issue or pull request related to .NET (6) dotnet-pri0 .NET 6: required for stable release
Projects
None yet
Milestone
.NET 6
Development

No branches or pull requests
2 participants
@spouliot @filipnavara