Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to turn off _CompileAppManifest for library projects #15031

Open
KirillOsenkov opened this issue May 13, 2022 · 4 comments
Open

Ability to turn off _CompileAppManifest for library projects #15031

KirillOsenkov opened this issue May 13, 2022 · 4 comments
Assignees
Labels
dotnet An issue or pull request related to .NET (6) enhancement The issue or pull request is an enhancement performance If an issue or pull request is related to performance
Milestone

Comments

@KirillOsenkov
Copy link
Member

We are seeing library projects targeting net6.0-macos where the target _CompileAppManifest and related targets run:

<!-- This target has no inputs, because it must still be run if there are no input app manifests, to set default values -->

I know it's not a lot of overhead, but my understanding that if we know the libraries definitely have nothing to do with MacOS perhaps we should be able to turn off this machinery?

Perhaps AppManifestDetectionEnabled should be respected in a condition in these targets?

See related:
#13583

I think most of these targets don't need to run for regular projects and we should be able to turn them off?

image

@KirillOsenkov
Copy link
Member Author

On the other hand, perhaps we should be targeting net6.0 instead of net6.0-macos in our library projects??

@KirillOsenkov
Copy link
Member Author

confirmed we need to target net6.0-macos because we use Cocoa APIs from libraries

@rolfbjarne rolfbjarne added enhancement The issue or pull request is an enhancement performance If an issue or pull request is related to performance dotnet An issue or pull request related to .NET (6) labels May 16, 2022
@rolfbjarne
Copy link
Member

Yeah, we could look into adding a property that disables app manifest logic for library projects.

@rolfbjarne rolfbjarne added this to the .NET 7 milestone May 16, 2022
@rolfbjarne rolfbjarne modified the milestones: .NET 7, .NET 8 Aug 26, 2022
@rolfbjarne rolfbjarne modified the milestones: .NET 8, .NET 9 Sep 7, 2023
@rolfbjarne
Copy link
Member

This will be fixed with the fix for #19028 (whenever we get to do that).

@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 26, 2024
@rolfbjarne rolfbjarne self-assigned this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet An issue or pull request related to .NET (6) enhancement The issue or pull request is an enhancement performance If an issue or pull request is related to performance
Projects
None yet
Development

No branches or pull requests

2 participants