Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass linker flag to set __THUNKS permission for NativeAOT #17629

Closed
Tracked by #17339
akoeplinger opened this issue Feb 27, 2023 · 2 comments
Closed
Tracked by #17339

Pass linker flag to set __THUNKS permission for NativeAOT #17629

akoeplinger opened this issue Feb 27, 2023 · 2 comments
Assignees
Milestone

Comments

@akoeplinger
Copy link
Member

dotnet/runtime#82317 implemented marshalled delegate support for NativeAOT via generating thunk pages.
We need the -Wl,-segprot,__THUNKS,rx,rx linker flag to set the correct permissions on the segment.

Note: depending on how we'll integrate the NativeAOT targets into xamarin-macios this might be automatically handled, filing this just so we don't forget it if we don't use the NativeAOT targets.

@rolfbjarne
Copy link
Member

@akoeplinger I believe we don't need to do anything here, the logic to pass these linker flags was implemented in dotnet/runtime here: dotnet/runtime@75a32b8

@filipnavara
Copy link
Contributor

Yep, we can close this. As long as the linker flags are inherited from the NativeAOT logic we should be fine.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants