[xcode16] Use [Experimental] instead of [RequiresPreviewFeatures]. #21178

rolfbjarne · 2024-09-03T18:53:21Z

This is because EnablePreviewFeatures=true doesn't quite work, since it
requires the building .NET and the target .NET to be on the same version.
We're might want to build with .NET 9, but the Xcode branch is targeting .NET
8, so it doesn't work.

This behavior is explained here:
https://github.com/dotnet/designs/blob/main/accepted/2021/preview-features/preview-features.md#meaning-of-property-in-multi-targeted-projects

The best solution seems to switch to using the Experimental attribute instead,
which was designed for our scenario (and explicitly to fix the problem we're
running into): https://github.com/dotnet/designs/blob/bba3216250cb29b0063bac3ebb57a542ee21ad4f/accepted/2023/preview-apis/preview-apis.md

This also meant we had to augment -nowarn for bgen to:

Pass any nowarn values to the compiler when bgen compiles stuff.
Pass $(NoWarn) (the MSBuild property) to bgen when building a binding project.

This is because `EnablePreviewFeatures=true` doesn't quite work, since it requires the building .NET and the target .NET to be on the same version. We're might want to build with .NET 9, but the Xcode branch is targeting .NET 8, so it doesn't work. This behavior is explained here: https://github.com/dotnet/designs/blob/main/accepted/2021/preview-features/preview-features.md#meaning-of-property-in-multi-targeted-projects The best solution seems to switch to using the Experimental attribute instead, which was designed for our scenario (and explicitly to fix the problem we're running into): https://github.com/dotnet/designs/blob/bba3216250cb29b0063bac3ebb57a542ee21ad4f/accepted/2023/preview-apis/preview-apis.md

github-actions · 2024-09-03T18:56:55Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

dalexsoto

Looking good!

docs/preview-apis.md

tests/common/Configuration.cs

Co-authored-by: Alex Soto <alex@soto.dev>

…s version. Looking at Xcode's version doesn't work on Windows.

…xperimental

vs-mobiletools-engineering-service2 · 2024-09-09T19:01:06Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 9f5ca6447c0967d823f259338734ff41aec6f1e1 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-09T19:02:28Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: 9f5ca6447c0967d823f259338734ff41aec6f1e1 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-09T19:03:54Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 9f5ca6447c0967d823f259338734ff41aec6f1e1 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-09T19:06:11Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 9f5ca6447c0967d823f259338734ff41aec6f1e1 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-09T19:32:18Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 9f5ca6447c0967d823f259338734ff41aec6f1e1 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-10T11:47:24Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 100 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. [attempt 4] Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
⚠️ mac-binding-project: No tests selected. Html Report (VSDrops) Download
⚠️ mmp: No tests selected. Html Report (VSDrops) Download
⚠️ mononative: No tests selected. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
⚠️ mtouch: No tests selected. Html Report (VSDrops) Download
⚠️ xammac: No tests selected. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 9f5ca6447c0967d823f259338734ff41aec6f1e1 [PR build]

rolfbjarne and others added 2 commits September 3, 2024 20:53

Auto-format source code

7637c94