Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[generate-type-forwarders] Fix incorrect overrides on methods and properties #10978

Merged
merged 1 commit into from
Mar 26, 2021
Merged

[generate-type-forwarders] Fix incorrect overrides on methods and properties #10978

merged 1 commit into from
Mar 26, 2021

Conversation

spouliot
Copy link
Contributor

Examples

Modified properties:

-public virtual SceneKit.SCNScene Scene { get; set; }
+public override SceneKit.SCNScene Scene { get; set; }

Modified methods:

-public virtual void CancelRequest (Foundation.NSError error)
+public override void CancelRequest (Foundation.NSError error)

[generate-type-forwarders] Fix incorrect overrides on methods and pro…
1e945b1 
…perties

Examples

Modified properties:

```diff
-public virtual SceneKit.SCNScene Scene { get; set; }
+public override SceneKit.SCNScene Scene { get; set; }
```

Modified methods:

```diff
-public virtual void CancelRequest (Foundation.NSError error)
+public override void CancelRequest (Foundation.NSError error)
```
@spouliot spouliot added the not-notes-worthy Ignore for release notes label Mar 26, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

🎉 All 182 tests passed 🎉

Pipeline on Agent XAMBOT-1095

@spouliot spouliot merged commit fc5c571 into dotnet:main Mar 26, 2021
@spouliot spouliot deleted the gtf-fix-overrides branch March 26, 2021 13:34
tj-devel709 pushed a commit that referenced this pull request Apr 7, 2021
@spouliot
[generate-type-forwarders] Fix incorrect overrides on methods and pro…
02c1382 
…perties (#10978)

Examples

Modified properties:

```diff
-public virtual SceneKit.SCNScene Scene { get; set; }
+public override SceneKit.SCNScene Scene { get; set; }
```

Modified methods:

```diff
-public virtual void CancelRequest (Foundation.NSError error)
+public override void CancelRequest (Foundation.NSError error)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spouliot @vs-mobiletools-engineering-service2 @rolfbjarne