[CI] Re-enable API and Generator diff. #11187
Conversation
Use the jenkins script as a base to get the PAI & generator from stable diff back to the CI. Comment is not perfect, but does provide the required information. The comment can be improve in a later commit since this is getting too large.
|
Sample commit from the tests: c846033#commitcomment-49333692 We should get a similar one here nevertheless. |
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) ✅ Generator Diff (no change) Test results1 tests failed, 97 tests passed.Failed tests
Pipeline on Agent XAMBOT-1106' |
|
@spouliot I know: "The comment can be improve in a later commit since |
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) Test results4 tests failed, 94 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur |
There was a problem hiding this comment.
@mandel-macaque do a small binding change in a commit
that will make API diff and generator diff generate something (non empty)
and then revert it - that will make the reports empty again
and proving the PR works as intended :)
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) Test results1 tests failed, 98 tests passed.Failed tests
|
…common one as a base.
mandel-macaque
force-pushed
the
error-api-changes
branch
from
e008649 to
c470b6b
Compare
| # set the env vars that are required for the compare to work. XAM_TOP is not set because | ||
| # the yaml takes care of that. | ||
| export WORKSPACE="$BUILD_ARTIFACTSTAGINGDIRECTORY" | ||
| echo "GH PR: $ghprbPullId" |
There was a problem hiding this comment.
You're not calling compare.sh here.
| @@ -0,0 +1,4 @@ | |||
| # set the env vars that are required for the compare to work. XAM_TOP is not set because | |||
There was a problem hiding this comment.
Maybe start with #!/bin/bash -e?
✅ Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) 🎉 All 102 tests passed 🎉 |
✅ Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) 🎉 All 102 tests passed 🎉 |
|
Do not merge label per Manuel's request |
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) Test results1 tests failed, 103 tests passed.Failed tests
|
|
@spouliot success: #11244 (comment) there are two improvements I want to do, but we are good to land AFAIK |
✅ Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) 🎉 All 104 tests passed 🎉Pipeline on Agent XAMBOT-1103.BigSur |
|
/sudo xcode12.5 |
|
/sudo backport xcode12.5 |
|
/sudo backport d16-10 |
|
Backport Job to branch xcode12.5 Created! The magic is happening here |
|
Backport Job to branch d16-10 Created! The magic is happening here |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4708923 for more details. |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4708926 for more details. |
Use the jenkins script as a base to get the PAI & generator from stable diff back to the CI. Comment is not perfect, but does provide the required information. The comment can be improve in a later commit since this is getting too large.
Use the jenkins script as a base to get the PAI & generator from stable diff back to the CI. Comment is not perfect, but does provide the required information. The comment can be improve in a later commit since this is getting too large.
|
/sudo backport release/6.0.1xx-preview4 |
|
Backport Job to branch release/6.0.1xx-preview4 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4711179 for more details. |
Use the jenkins script as a base to get the PAI & generator from stable diff back to the CI. Comment is not perfect, but does provide the required information. The comment can be improve in a later commit since this is getting too large.
Use the jenkins script as a base to get the PAI & generator from stable diff back to the CI. Comment is not perfect, but does provide the required information. The comment can be improve in a later commit since this is getting too large.
Use the jenkins script as a base to get the PAI & generator from stable
diff back to the CI. Comment is not perfect, but does provide the
required information. The comment can be improve in a later commit since
this is getting too large.