Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShazamKit] Updates Xcode13 beta1 #12189

Merged
merged 23 commits into from
Aug 17, 2021
+280 −340
Merged

[ShazamKit] Updates Xcode13 beta1 #12189

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
88b1f61
initial changes
Jul 22, 2021
f4aefd2
forgot a comma
Jul 22, 2021
92812fa
adding common ignore and new framework locations
Jul 23, 2021
7ec97c4
fixing capitalization and adding DisableDefaultConstructor
Jul 23, 2021
0003b4a
newlines in attributes
Jul 23, 2021
59232d9
Merge branch 'main' into Xcode13-ShazamKit-beta1
mandel-macaque Jul 29, 2021
db776fb
Merge remote-tracking branch 'xamarin/main' into Xcode13-ShazamKit-beta1
Aug 4, 2021
c25ee39
run tests on device only
Aug 5, 2021
dc06158
Merge remote-tracking branch 'TJ/Xcode13-ShazamKit-beta1' into Xcode1…
Aug 5, 2021
d1eb2f6
name changes and checking for simulator
Aug 5, 2021
e7b0874
Merge branch 'main' into Xcode13-ShazamKit-beta1
tj-devel709 Aug 5, 2021
5cff855
Merge remote-tracking branch 'xamarin/main' into Xcode13-ShazamKit-beta1
Aug 9, 2021
5aff644
forgot unavailable for swift
Aug 9, 2021
d369c6f
Merge remote-tracking branch 'TJ/Xcode13-ShazamKit-beta1' into Xcode1…
Aug 9, 2021
3b1d577
removing decoration
Aug 9, 2021
2960e20
syntax
Aug 10, 2021
96eb3ff
wrong line and adding in default constructor
Aug 11, 2021
956b8a9
Merge remote-tracking branch 'xamarin/main' into Xcode13-ShazamKit-beta1
Aug 11, 2021
9d43b29
alphabetical
Aug 11, 2021
f51f4d6
fixing tests
Aug 12, 2021
0b79901
Adding Simulator only in Frameworks.cs
Aug 13, 2021
acb7bf4
Merge remote-tracking branch 'xamarin/main' into Xcode13-ShazamKit-beta1
Aug 13, 2021
a8c1bc2
removing unnecessary attributes
Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
forgot unavailable for swift
tj_devel709 committed Aug 9, 2021
commit 5aff6440dd8176e3a8217bfecc2b2ea412efeb8d
1 change: 1 addition & 0 deletions src/shazamkit.cs
View file
Original file line number Diff line number Diff line change
@@ -81,6 +81,7 @@ interface SHCustomCatalog
bool Write (NSUrl url, [NullAllowed] out NSError error);

[Static]
[Unavailable (PlatformName.Swift)]
[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ that's a (incomplete) duplicate of the attributes on the type

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Removing now!

[Export ("new")]
[return: Release]