[Cinematic] Add support for Xcode 15 beta 6. #18686

mandel-macaque · 2023-08-09T21:45:38Z

No description provided.

github-actions · 2023-08-09T21:49:46Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

src/rsp/dotnet/ios-defines-dotnet.rsp

src/rsp/dotnet/maccatalyst-defines-dotnet.rsp

src/rsp/dotnet/macos-defines-dotnet.rsp

src/rsp/dotnet/tvos-defines-dotnet.rsp

src/rsp/ios-defines.rsp

src/rsp/macos-defines.rsp

src/rsp/tvos-defines.rsp

mandel-macaque · 2023-08-17T17:34:22Z

src/Cinematic/CNDecision.cs

+
+	public partial class CNDecision {
+
+		public CNDecision (CMTime time, long detectionID, bool isStrong, CNDecisionIdentifierType identifierType)


No need for attr using the default ones from the class.

src/Cinematic/CNDecision.cs

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2023-08-25T18:21:00Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-25T18:23:03Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: dee710f8d08f77009b11298a38be3ba201f78f0f [PR build]

vs-mobiletools-engineering-service2 · 2023-08-25T18:27:23Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-25T18:38:57Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
~~watchOS~~ (no change detected)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
~~MacCatalyst~~: (empty diff detected)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: dee710f8d08f77009b11298a38be3ba201f78f0f [PR build]

vs-mobiletools-engineering-service2 · 2023-08-25T18:48:18Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-28T11:35:05Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 237 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch: All 38 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: dee710f8d08f77009b11298a38be3ba201f78f0f [PR build]

mandel-macaque requested review from rolfbjarne and dalexsoto as code owners August 9, 2023 21:45

mandel-macaque marked this pull request as draft August 9, 2023 21:45

This comment has been minimized.

Sign in to view

mandel-macaque commented Aug 9, 2023

View reviewed changes

src/rsp/dotnet/ios-defines-dotnet.rsp Outdated Show resolved Hide resolved

mandel-macaque commented Aug 9, 2023

View reviewed changes

src/rsp/dotnet/maccatalyst-defines-dotnet.rsp Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

mandel-macaque commented Aug 9, 2023

View reviewed changes

src/rsp/dotnet/macos-defines-dotnet.rsp Outdated Show resolved Hide resolved

mandel-macaque commented Aug 9, 2023

View reviewed changes

src/rsp/dotnet/tvos-defines-dotnet.rsp Outdated Show resolved Hide resolved

mandel-macaque commented Aug 9, 2023

View reviewed changes

src/rsp/ios-defines.rsp Outdated Show resolved Hide resolved

mandel-macaque commented Aug 9, 2023

View reviewed changes

src/rsp/macos-defines.rsp Outdated Show resolved Hide resolved

mandel-macaque commented Aug 9, 2023

View reviewed changes

src/rsp/tvos-defines.rsp Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

mandel-macaque force-pushed the net8.0-xcode15-cinematic branch 2 times, most recently from d0b3ba2 to e6ec0fc Compare August 17, 2023 17:33

mandel-macaque commented Aug 17, 2023

View reviewed changes

[Cinematic] Add support for Xcode 15 beta 5.

b791d02

mandel-macaque force-pushed the net8.0-xcode15-cinematic branch from e6ec0fc to b791d02 Compare August 17, 2023 17:36

mandel-macaque marked this pull request as ready for review August 17, 2023 17:36

mandel-macaque commented Aug 17, 2023

View reviewed changes

src/Cinematic/CNDecision.cs Outdated Show resolved Hide resolved

haritha-mohan approved these changes Aug 22, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Aug 23, 2023

View reviewed changes

src/Cinematic/CNDecision.cs Outdated Show resolved Hide resolved

mandel-macaque and others added 3 commits August 23, 2023 10:56

Update src/Cinematic/CNDecision.cs

3c1c2d4

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Update src/cinematic.cs

25511a6

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>

Merge branch 'net8.0-xcode15' into net8.0-xcode15-cinematic

c00102c

This comment has been minimized.

Sign in to view

Remove cinematic from catalyst since it is not present.

3ea1786

This comment has been minimized.

Sign in to view

Fix attrs for maccatalyst in avfoundation.

dee710f

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Aug 28, 2023

View reviewed changes

mandel-macaque merged commit 642889a into xamarin:net8.0-xcode15 Aug 28, 2023
52 checks passed

mandel-macaque deleted the net8.0-xcode15-cinematic branch August 28, 2023 18:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cinematic] Add support for Xcode 15 beta 6. #18686

[Cinematic] Add support for Xcode 15 beta 6. #18686

mandel-macaque commented Aug 9, 2023

github-actions bot commented Aug 9, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque Aug 17, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 25, 2023

vs-mobiletools-engineering-service2 commented Aug 25, 2023

vs-mobiletools-engineering-service2 commented Aug 25, 2023

vs-mobiletools-engineering-service2 commented Aug 25, 2023

vs-mobiletools-engineering-service2 commented Aug 25, 2023

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 28, 2023


		public partial class CNDecision {

		public CNDecision (CMTime time, long detectionID, bool isStrong, CNDecisionIdentifierType identifierType)

[Cinematic] Add support for Xcode 15 beta 6. #18686

[Cinematic] Add support for Xcode 15 beta 6. #18686

Conversation

mandel-macaque commented Aug 9, 2023

github-actions bot commented Aug 9, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque Aug 17, 2023

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 25, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Aug 25, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Aug 25, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Aug 25, 2023

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Aug 25, 2023

📚 [PR Build] Artifacts 📚

Packages generated

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 28, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts