[PassKit] Implement Xcode 16.0 beta 1-6 changes. #21139

rolfbjarne · 2024-08-28T16:53:24Z

Note: there were no changes in beta 3, beta 4 or beta 5.

Note: there were no changes in beta 3, beta 4 or beta 5. Draft because: * A few types changed base type: check API diff to verify if this works out, and remove commented out code. * Some changes will come in a different PR (Dlfcn + generator changes).

…6-passkit

vs-mobiletools-engineering-service2 · 2024-09-06T12:05:23Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: a0c1253022b95baddf0b8b591b4dcdb5b275a4f0 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-06T12:07:17Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: a0c1253022b95baddf0b8b591b4dcdb5b275a4f0 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-06T12:07:32Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: a0c1253022b95baddf0b8b591b4dcdb5b275a4f0 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-06T12:08:17Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: a0c1253022b95baddf0b8b591b4dcdb5b275a4f0 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-06T22:42:21Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: a0c1253022b95baddf0b8b591b4dcdb5b275a4f0 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-09T11:34:30Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 4 tests failed, 169 tests passed.

Failures

❌ monotouch tests (watchOS) [attempt 2]

4 tests failed, 0 tests passed.

monotouch-test/watchOS 32-bits - simulator/Debug: BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): BuildFailure

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 6 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: a0c1253022b95baddf0b8b591b4dcdb5b275a4f0 [PR build]

rolfbjarne · 2024-09-11T10:31:03Z

Test failure is not irrelevant, because it's a legacy-only test failure, and we've dropped support for legacy.

mcumming · 2024-09-11T12:52:20Z

tests/monotouch-test/PassKit/PKJapanIndividualNumberCardMetadataTest.cs

+ using var obj = new PKJapanIndividualNumberCardMetadata ("credentialIdentifier", "sharingInstanceIdentifier", "cardTemplateIdentifier", preview, PKJapanIndividualNumberCardMetadataConstructorOption.CardTemplateIdentifier);
+ Assert.IsNull (obj.AuthenticationPassword, "AuthenticationPassword");
+ Assert.IsNull (obj.SigningPassword, "SigningPassword");
+ // There doesn't seem to be an easy way to verify that the ctor actually worked


Wouldn't that be a) it didn't throw, and b) obj is not null, for simplicity?

Both of those conditions are verified in the test (indirectly).

What I meant by the comment is that there's no way to check that the parameters to the constructor actually made it correctly to the native code, because the type doesn't have corresponding (readonly) properties to read those values back.

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits September 3, 2024 15:51

Merge remote-tracking branch 'origin/xcode16' into dev/rolf/xcode16-b…

cc4c371

…6-passkit

Try something.

ddb119f

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits September 4, 2024 15:04

Improve API.

5a5b8b9

Merge remote-tracking branch 'origin/xcode16' into dev/rolf/xcode16-b…

7603629

…6-passkit

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits September 5, 2024 15:09

Update stuff.

c62f593

Merge remote-tracking branch 'origin/xcode16' into dev/rolf/xcode16-b…

a0c1253

…6-passkit

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review September 11, 2024 10:31

dalexsoto approved these changes Sep 11, 2024

View reviewed changes

mcumming reviewed Sep 11, 2024

View reviewed changes

mcumming approved these changes Sep 11, 2024

View reviewed changes

rolfbjarne merged commit f7bddc6 into xcode16 Sep 12, 2024
25 of 27 checks passed

rolfbjarne deleted the dev/rolf/xcode16-b6-passkit branch September 12, 2024 11:10

[PassKit] Implement Xcode 16.0 beta 1-6 changes. #21139

[PassKit] Implement Xcode 16.0 beta 1-6 changes. #21139

Conversation

rolfbjarne commented Aug 28, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 6, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Sep 6, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Sep 6, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

vs-mobiletools-engineering-service2 commented Sep 6, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 6, 2024

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Sep 9, 2024

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ monotouch tests (watchOS) [attempt 2]

Successes

rolfbjarne commented Sep 11, 2024

mcumming Sep 11, 2024

Choose a reason for hiding this comment

rolfbjarne Sep 11, 2024

Choose a reason for hiding this comment

rolfbjarne commented Aug 28, 2024 •

edited

Loading