Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HealthKit] Implement Xcode 16.0 beta 1-6 changes. #21146

Merged
merged 4 commits into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/HealthKit/Enums.cs
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,11 @@ public enum HKCategoryValueCervicalMucusQuality : long {
[Mac (13, 0)]
[MacCatalyst (13, 1)]
[Native]
[Deprecated (PlatformName.iOS, 18, 0, message: "Use 'HKCategoryValueVaginalBleeding' instead.")]
[Deprecated (PlatformName.MacCatalyst, 18, 0, message: "Use 'HKCategoryValueVaginalBleeding' instead.")]
[Deprecated (PlatformName.TvOS, 18, 0, message: "Use 'HKCategoryValueVaginalBleeding' instead.")]
[Deprecated (PlatformName.WatchOS, 11, 0, message: "Use 'HKCategoryValueVaginalBleeding' instead.")]
[Deprecated (PlatformName.MacOSX, 15, 0, message: "Use 'HKCategoryValueVaginalBleeding' instead.")]
public enum HKCategoryValueMenstrualFlow : long {
NotApplicable = 0,
Unspecified = 1,
Expand All @@ -381,6 +386,16 @@ public enum HKCategoryValueMenstrualFlow : long {
None,
}

[Watch (11, 0), TV (18, 0), Mac (15, 0), iOS (18, 0), MacCatalyst (18, 0)]
[Native]
public enum HKCategoryValueVaginalBleeding : long {
Unspecified = 1,
Light = 2,
Medium = 3,
Heavy = 4,
None = 5,
}

/// <summary>Enumerates the results of an ovulation test.</summary>
[Mac (13, 0)]
[MacCatalyst (13, 1)]
Expand Down
34 changes: 34 additions & 0 deletions src/HealthKit/HKSupportFunctions.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
#nullable enable

using System;
using System.Runtime.InteropServices;

using Foundation;
using ObjCRuntime;

namespace HealthKit {
/// <summary>This class contains helper functions for the <see cref="HKStateOfMindValenceClassification" /> enum.</summary>
#if NET
[SupportedOSPlatform ("ios18.0")]
[SupportedOSPlatform ("maccatalyst18.0")]
[SupportedOSPlatform ("macos15.0")]
[UnsupportedOSPlatform ("tvos")]
#else
[Watch (11, 0), NoTV, Mac (15, 0), iOS (18, 0), MacCatalyst (18, 0)]
#endif
public static class HKStateOfMindValence {
[DllImport (Constants.HealthKitLibrary)]
static extern IntPtr HKStateOfMindValenceClassificationForValence (double valence);

/// <summary>Gets the valence classification appropriate for a given valence value.</summary>
/// <param name="valence">The valence value whose classification to get.</param>
/// <returns>The valence classification, or null if the specified valence is outside of the supported range of valence values.</returns>
public static HKStateOfMindValenceClassification? GetClassification (double valence)
{
var nsnumber = Runtime.GetNSObject<NSNumber> (HKStateOfMindValenceClassificationForValence (valence), owns: false);
if (nsnumber is null)
return null;
return (HKStateOfMindValenceClassification) (long) nsnumber.LongValue;
}
}
}
1 change: 1 addition & 0 deletions src/frameworks.sources
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,7 @@ HEALTHKIT_SOURCES = \
HealthKit/HKObjectType.cs \
HealthKit/HKObsolete.cs \
HealthKit/HKSampleQuery.cs \
HealthKit/HKSupportFunctions.cs \
HealthKit/HKUnit.cs \

# HealthKitUI
Expand Down
418 changes: 407 additions & 11 deletions src/healthkit.cs

Large diffs are not rendered by default.

130 changes: 130 additions & 0 deletions tests/cecil-tests/Documentation.KnownFailures.txt

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions tests/monotouch-test/HealthKit/CategoryTypeIdentifierTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,12 @@ public void EnumValues_22351 ()
if (!TestRuntime.CheckXcodeVersion (14, 1))
continue;
break;

case HKCategoryTypeIdentifier.BleedingAfterPregnancy:
case HKCategoryTypeIdentifier.BleedingDuringPregnancy:
if (!TestRuntime.CheckXcodeVersion (16, 0))
continue;
break;
default:
if (!TestRuntime.CheckXcodeVersion (7, 0))
continue;
Expand Down
12 changes: 12 additions & 0 deletions tests/monotouch-test/HealthKit/QuantityTypeIdentifierTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,18 @@ public void EnumValues_22351 ()
if (!TestRuntime.CheckXcodeVersion (15, 0))
continue;
break;
case HKQuantityTypeIdentifier.CrossCountrySkiingSpeed:
case HKQuantityTypeIdentifier.DistanceCrossCountrySkiing:
case HKQuantityTypeIdentifier.DistancePaddleSports:
case HKQuantityTypeIdentifier.DistanceRowing:
case HKQuantityTypeIdentifier.DistanceSkatingSports:
case HKQuantityTypeIdentifier.EstimatedWorkoutEffortScore:
case HKQuantityTypeIdentifier.PaddleSportsSpeed:
case HKQuantityTypeIdentifier.RowingSpeed:
case HKQuantityTypeIdentifier.WorkoutEffortScore:
if (!TestRuntime.CheckXcodeVersion (16, 0))
continue;
break;
}

try {
Expand Down

This file was deleted.

68 changes: 0 additions & 68 deletions tests/xtro-sharpie/api-annotations-dotnet/iOS-HealthKit.todo

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# intro reports them as not present
# xtro says 'workoutSessionMirroringStartHandler' exists on macOS, introspection disagrees.
# Headers doesn't say neither that it's available nor that it's not on macOS, which is probably why xtro picks it up (defaults to available).
# Assuming that the lack of unavailability in the headers is a mistake, so remove from macOS.
!missing-selector! HKHealthStore::setWorkoutSessionMirroringStartHandler: not bound
!missing-selector! HKHealthStore::workoutSessionMirroringStartHandler not bound
68 changes: 0 additions & 68 deletions tests/xtro-sharpie/api-annotations-dotnet/macOS-HealthKit.todo

This file was deleted.

Loading
Loading