quality-gate: capture more unnecessary List.length cases

Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>

Author: psafont

ocaml/sdk-gen/c/gen_c_binding.ml

@@ -346,7 +346,7 @@ and gen_impl cls =
       ; ("async_params", `A (List.map paramJson (asyncParams msg)))
       ; ("msg_params", `A (List.map paramJson msg.msg_params))
       ; ("abstract_result_type", `String (result_type msg))
-      ; ("has_params", `Bool (List.length msg.msg_params <> 0))
+      ; ("has_params", `Bool (msg.msg_params <> []))
       ; ("param_count", `String (string_of_int (List.length msg.msg_params)))
       ; ("has_result", `Bool (String.compare (result_type msg) "" <> 0))
       ; ("init_result", `Bool (init_result msg))

ocaml/xapi/repository.ml

@@ -232,7 +232,7 @@ let sync ~__context ~self ~token ~token_id ~username ~password =
     Xapi_stdext_pervasives.Pervasiveext.finally
       (fun () ->
         let config_repo config =
-          if List.length config <> 0 then (* Set params to yum/dnf *)
+          if config <> [] then (* Set params to yum/dnf *)
             let Pkg_mgr.{cmd; params} = Pkgs.config_repo ~repo_name ~config in
             ignore
               (Helpers.call_script ~log_output:Helpers.On_failure cmd params)

ocaml/xapi/xapi_vm_lifecycle.ml

@@ -507,9 +507,7 @@ let check_operation_error ~__context ~ref =
     (* if other operations are in progress, check that the new operation is allowed concurrently with them. *)
     let current_error =
       check current_error (fun () ->
-          if
-            List.length current_ops <> 0
-            && not (is_allowed_concurrently ~op ~current_ops)
+          if current_ops <> [] && not (is_allowed_concurrently ~op ~current_ops)
           then
             report_concurrent_operations_error ~current_ops ~ref_str
           else

quality-gate.sh

@@ -130,7 +130,9 @@ unnecessary-length () {
   UNNECESSARY_LENGTH=$(local_grep "List.length.*=+\s*0")
   UNNECESSARY_LENGTH=$((UNNECESSARY_LENGTH+$(local_grep "0\s*=+\s*List.length")))
   UNNECESSARY_LENGTH=$((UNNECESSARY_LENGTH+$(local_grep "List.length.*\s>\s*0")))
+  UNNECESSARY_LENGTH=$((UNNECESSARY_LENGTH+$(local_grep "List.length.*\s<>\s*0")))
   UNNECESSARY_LENGTH=$((UNNECESSARY_LENGTH+$(local_grep "0\s*<\s*List.length")))
+  UNNECESSARY_LENGTH=$((UNNECESSARY_LENGTH+$(local_grep "0\s*<>\s*List.length")))
   UNNECESSARY_LENGTH=$((UNNECESSARY_LENGTH+$(local_grep "List.length.*\s<\s*1")))
   UNNECESSARY_LENGTH=$((UNNECESSARY_LENGTH+$(local_grep "1\s*>\s*List.length")))
   if [ "$UNNECESSARY_LENGTH" -eq "$N" ]; then