-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues when running flox
with chunked pint arrays
#163
Comments
OK that wont work but it should have not gone down this code path at all in xarray. But it looks like I only tested pure pint arrays not pint + dask: It'd be nice to add full pint support here but it'll be a bit of effort. Are you interested in working on it? |
@dcherian sorry for the delay here. I could work on this effort, but unfortunately only on weekends, so it might be a long process. I would appreciate some guidance if you have some time (either over chat here or a zoom call) on which parts of the code to target, since I haven't worked closely with the package. My current solution is to |
Thanks for offering to help @riley-brady
I think this is what we'll have to do since pint's support for ufuncs isn't great apparently. lets strip array units if any right at the beginning, and reapply it at the end Line 1641 in e3ea0e7
|
After upgrading to the latest
xarray
version and installingflox
, I find that chunkedpint
arrays break with the.resample()
method. I'm posting this here instead ofpint_xarray
since it looks like from the traceback this is coming fromflox
.I imagine this has to do with the complexity of working with duck-arrays like
pint_xarray
.Possible related threads:
rolling()
pint-xarray#186The text was updated successfully, but these errors were encountered: