Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep attributes after conservative regridding #26

Closed
kjdoore opened this issue Feb 12, 2024 · 3 comments · Fixed by #27
Closed

Keep attributes after conservative regridding #26

kjdoore opened this issue Feb 12, 2024 · 3 comments · Fixed by #27

Comments

@kjdoore
Copy link
Collaborator

kjdoore commented Feb 12, 2024

When regridding a data set using the conservative method, all attributes from the original xarray object are lost. It would be nice if those attributes could remain attached to the regridded data set like the linear method.

@BSchilperoort
Copy link
Contributor

Hi Keith, thanks for opening this issue! I hope that the package has been useful for you. I have added tests for this, and fixed the issue in #27.

Would you be willing/able to review the PR? Then I'll mark you as reviewer. If you're unsure about this that OK.

@BSchilperoort BSchilperoort linked a pull request Feb 12, 2024 that will close this issue
@kjdoore
Copy link
Collaborator Author

kjdoore commented Feb 12, 2024

Hi Bart, thanks for updating this so quickly! I would be happy to review the PR for you.

I have a project that I am working on that currently uses xESMF, but I am trying to switch away from it due to its large dependencies and the preference of using xarray add-ons vs specific packages. I have another issue related to the handling of NaNs that I have noticed, which I will bring up as new issues.

@BSchilperoort
Copy link
Contributor

I have added you as a collaborator, if you could leave a review that'd be great.

The heaviness of xESMF and other packages is exactly why I started this package. And of course ESMF is not available on e.g. Windows which was a downside we encountered in other projects.

Any other issues would be very welcome, that'd really help with improving this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants