fix: remove format fix #88
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant GitHub
Client->>GitHub: Send request with response_format
GitHub->>Client: Return response based on format
alt If format is unsupported
GitHub-->>Client: Throw error
end
Possibly related PRs
Warning Rate limit exceeded@xavidop has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 4 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
src/github_llms.ts (1)
Line range hint
754-756: Improve error message clarityThe error message could be more specific by including the model name and supported formats.
- throw new Error( - `${response_format} format is not supported for GPT models currently`, - ); + throw new Error( + `Format '${response_format}' is not supported for model '${modelName}'. Supported formats: ${model.info.supports?.output?.join(", ")}`, + );
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
src/github_llms.ts(2 hunks)
🔇 Additional comments (1)
src/github_llms.ts (1)
736-737: LGTM! Changes successfully remove the format fix
The changes successfully streamline the response format handling by:
- Using a single
response_formatcheck instead of separate boolean flags - Properly checking model support for each format
Also applies to: 746-748
|
|
🎉 This PR is included in version 1.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Before you submit a pull request, please make sure you have read and understood the contribution guidelines and the code of conduct.
This pull request is related to:
I have checked the following:
Description:
removes the hot fix for structured output.
Related issues:
Please, link the related issues that this pull request will resolve here (if any).
Summary by CodeRabbit