Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Feature: smooth_power_on #15

Closed
davidclemens opened this issue Jan 25, 2020 · 3 comments
Closed

Enhance Feature: smooth_power_on #15

davidclemens opened this issue Jan 25, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@davidclemens
Copy link

I love the smooth_power_on feature.
It would be great if you could extent the functionality to all 4 outer buttons on the E1524 with the following or similar mapping if pushed while the light is off:

  • brightness_up -> turn on @ 255 brightness (with previous color/color_temp)
  • brightness_down -> turn on @ 1 brightness (with previous color/color_temp)
  • left -> turn on @ 153 mireds (with previous brightness)
  • right -> turn on @ 500 mireds (with previous brightness)

That would be great. Maybe you could define new actions from this like "brightness_up_from_off".
It would be even greater, if this mapping was also user configurable. For example like:

brightness_up_from_off:
brightness: 1
mireds: 327
brightness_down_from_off:
brightness: 255
mireds: previous
arrow_left_from_off:
brightness: previous
mireds: 153

and so on.

This would maybe tie in with issue #12.

Thanks a lot!

@xaviml
Copy link
Owner

xaviml commented Jan 31, 2020

Hi @davidclemens

Thanks for the idea. I am currently refactoring the project, so I will consider this once I finish with it and I might consider it to impement this with a CustomController (#12) as you said.

@xaviml xaviml self-assigned this Feb 14, 2020
@xaviml xaviml added the enhancement New feature or request label Feb 14, 2020
@xaviml
Copy link
Owner

xaviml commented Feb 18, 2020

Hi @davidclemens,

I recently released a beta version v2.3.0b1 with the new functionality for custom controllers. This new feature allows users to configure the behaviour for the controllers through yaml configuration. From now on, you will be able to do what you wanted with the power of custom controllers and callback constraints. I prepared a configuration that does what you want. It can also be found in the examples page.

livingroom_light_on:
  module: controllerx
  class: E1810Controller
  controller: sensor.livingroom_controller_action
  integration: z2m
  light: light.livingroom
  constrain_input_boolean: light.livingroom,on
  
livingroom_light_off:
  module: controllerx
  class: CustomLightController
  controller: sensor.livingroom_controller_action
  integration: z2m
  light: light.livingroom
  mapping:
    toggle: toggle
    brightness_up_click: on_full_brightness
    brightness_down_click: on_min_brightness
    brightness_up_hold: on_full_brightness
    brightness_down_hold: on_min_brightness
    arrow_right_click: on_full_color_temp
    arrow_left_click: on_min_color_temp
    arrow_right_hold: on_full_color_temp
    arrow_left_hold: on_min_color_temp
  constrain_input_boolean: light.livingroom,off

If you want to know more about custom controllers, you can check it out in here.

@xaviml xaviml closed this as completed Feb 18, 2020
@davidclemens
Copy link
Author

Thank you very much! Great work @xaviml !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants