Confusing log output buildKodi.groovy - Debug

[fuzzard]

I would probably put this down to more incorrect logging, but its definitely confusing for someone looking for the truth.

Android and webos both build Release, but reports Debug when "Default" is used (ie nightly job)

The following line is the cause of the following output in a job. Config is reported as debug.

pipeline-library/vars/buildKodi.groovy

Line 128 in 58d9214

echo "Building host: ${BUILD_HOST} config: ${CONFIGURATION} revision: ${Revision} repo: ${GITHUB_REPO}"

[Pipeline] stage
[Pipeline] { (Checkout Scm)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
Building host:   config: Debug revision: Omega repo: xbmc
[Pipeline] }
[Pipeline] // script

The debug is populated from the following initially (Default == Debug)

pipeline-library/vars/buildKodi.groovy

Line 47 in 58d9214

env.CONFIGURATION = params.Configuration == 'Release' ? 'Release' : 'Debug'

We then in a later stage, Environment Setup, change env.CONFIGURATION to the inverse (Default == Release)

pipeline-library/vars/buildKodi.groovy

Line 153 in 58d9214

env.CONFIGURATION = params.Configuration == 'Default' ? 'Release' : params.Configuration

We then see in the output from the "Build Depends" stage that we are indeed executing as Release (--disable-debug) which is populated from the following test to set the debug switch

pipeline-library/vars/buildKodi.groovy

Line 243 in 58d9214

env.DEBUG_SWITCH = env.CONFIGURATION == 'Release' ? '--disable-debug' : '--enable-debug'

[Pipeline] stage
[Pipeline] { (Build depends)
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ bash -c                           cd /home/jenkins/jenkins-root/workspace/android-arm-docker@2/tools/depends                           && git clean -xfd .                           && ./bootstrap                           && ./configure                             --with-tarballs=$WORKSPACE/../xbmc-tarballs                             --host=arm-linux-androideabi                             --prefix=/home/jenkins/jenkins-root/workspace/android-arm-docker@2/tools/depends/xbmc-depends                             -with-sdk-path=/home/jenkins/android-tools/android-sdk-linux --with-ndk-path=/home/jenkins/android-tools/android-sdk-linux/ndk/21.4.7075529                             --disable-debug                           && make -j64  

In the old buildsteps, it was changed so that Default was RelWithDebInfo for reasons, so the build type is in general "correct" for what was intended xbmc/xbmc@b0092bf

I would guess the easiest way forward is just to remove the log line at

pipeline-library/vars/buildKodi.groovy

Line 128 in 58d9214

echo "Building host: ${BUILD_HOST} config: ${CONFIGURATION} revision: ${Revision} repo: ${GITHUB_REPO}"

Maybe just relocating it at the end of the "Environment Setup" step where some platforms (Android, webos) make a change to the env.CONFIGURATION to still provide that log info early in a jenkins job log for those that are needing to look for it.