Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_version_number should use PEP 440 format, not Semver #87

Closed
pont-us opened this issue Sep 12, 2024 · 0 comments · Fixed by #88
Closed

test_version_number should use PEP 440 format, not Semver #87

pont-us opened this issue Sep 12, 2024 · 0 comments · Fixed by #88
Assignees
@pont-us

Comments

@pont-us
Copy link
Member

pont-us commented Sep 12, 2024

Currently, CDSStoreTest::test_version_number incorrectly checks that the version number matches Semantic Versioning format. It should instead enforce PEP 440 format. The current (and valid) version number (0.9.4.dev0) is PEP 440 compliant but not Semver-compliant, causing the test to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pont-us pont-us

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make test_version_number use PEP 440, not Semver xcube-dev/xcube-cds
1 participant
@pont-us