Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new cargo lockfile format #299

Closed
jonasbb opened this issue Dec 5, 2019 · 5 comments
Closed

Add support for the new cargo lockfile format #299

jonasbb opened this issue Dec 5, 2019 · 5 comments

Comments

@jonasbb
Copy link

jonasbb commented Dec 5, 2019

Recently cargo nightly started produces lockfiles with the new format (rust-lang/cargo#7579).

Tarpaulin fails to compile tests, if it encounters such a log file. One instance can be found here. Tarpaulin fails with this message:

Error: "Failed to compile tests! Error: failed to parse lock file at: /home/travis/build/jonasbb/serde_with/Cargo.lock"

In my case I run Tarpaulin on a library and therefore do not commit the lockfile, which is why nightly now uses the new lockfile format.

@xd009642
Copy link
Owner

xd009642 commented Dec 5, 2019

There's now a new cargo_update branch this updates the tarpaulin cargo dependency to 0.40.0 and may solve the issue. I'll try it myself when I've got time to but in the meantime if you test it and report back I can fast track the merge/release 👍

@HaoXuan40404
Copy link

Same problem too

@jonasbb
Copy link
Author

jonasbb commented Dec 6, 2019

@xd009642 I started a try build with tarpaulin from the new branch. It passed on all Rust versions.
https://travis-ci.org/jonasbb/serde_with/builds/621365163
So this would fix the issue for me.

@xd009642
Copy link
Owner

xd009642 commented Dec 7, 2019

Awesome, well since it doesn't affect anything in terms of existing build functionality I've just pushed out another release. If you could try it out and confirm it now works this issue can be closed 😄

@xd009642
Copy link
Owner

xd009642 commented Dec 8, 2019

It's now released in 0.10.0 so closing this

@xd009642 xd009642 closed this as completed Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants