fix: remove current execution position when performing stop or continue dbgp operation. #367
Conversation
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
==========================================
+ Coverage 70.11% 70.39% +0.27%
==========================================
Files 5 5
Lines 1014 1010 -4
Branches 162 161 -1
==========================================
Hits 711 711
+ Misses 303 299 -4
Continue to review full report at Codecov.
|
zobo
force-pushed
the
fix-stopped-indicator
branch
from
c702cb1
to
38f0ed6
Compare
When the IDE requests a continue operation (step in, out, over, continue) it expects a Response and will remove the current execution position. With XDebug/DBGp the TCP connection will not send a response until another stop condition is encountered this may take an arbitrary amount of time. This change fixes this by doing some basic validation (is the threadId valid) and then sends a response before executing the continuation command. Closes xdebug#358
zobo
force-pushed
the
fix-stopped-indicator
branch
from
38f0ed6
to
37124d4
Compare
zobo
changed the title
|
I rebased the code to latest main and fixed the title to pass all checks. |
Handle them, where possible, with sendErrorResponse and OutputEvent in other cases.
Codecov Report
@@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 66.63% 66.72% +0.09%
==========================================
Files 6 6
Lines 1070 1070
Branches 172 168 -4
==========================================
+ Hits 713 714 +1
+ Misses 357 356 -1
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 1.14.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This update caused a problem when running the debug. When I run the debug it is closed automatically. I have already uninstalled and installed the plugin and also vscode, but the problem persists.
|
|
Bug came in with previous commits. Was fixed in 1.14.7 |
When the IDE requests a continue operation (step in, out, over, continue) it expects a Response and will remove the current execution position. With XDebug/DBGp the TCP connection will not send a response until another stop condition is encountered this may take an arbitrary amount of time.
This change fixes this by doing some basic validation (is the threadId valid) and then sends a response before executing the continuation command.
Closes #358