Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the Affine dialect #85

Closed
Dinistro opened this issue Mar 25, 2022 · 2 comments · Fixed by #94
Closed

Cleanup the Affine dialect #85

Dinistro opened this issue Mar 25, 2022 · 2 comments · Fixed by #94
Assignees

Comments

@Dinistro
Copy link
Collaborator

The affine dialect still uses new_op instead of actual classes. Furthermore, it is nowhere near feature completion as IntegerSets are not yet supported.
Either we change the existing operations to use IRDL or we drop the dialect completely. What do you think @math-fehr ?

@webmiche
Copy link
Collaborator

I saw some work in the linalg PR on it, so I feel that we should not drop it. I agree though that keeping zombie dialects around does not make a lot of sense, so I guess things that do not get updated should be removed probably.

@Dinistro
Copy link
Collaborator Author

The PR does not touch the existing operations, thus I suggest that we simply rewrite them to use IRDL.

@Dinistro Dinistro self-assigned this Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants