Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify in the docs that the cache is used throughout the whole execution of a fetch #106

Open
ghost opened this issue Feb 28, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Feb 28, 2017

Spotted in the gitter channel

The big thing for me was that it wasn't clear that the cache could be reused. It talks about the state monad and the cache being immutable which caused me to make some bad assumptions, even after diving into the code.

This should be more explicit and clear to not confuse people.

@ghost ghost self-assigned this Feb 28, 2017
@tomjadams
Copy link

I'd also add that it can be reused between fetches also, i.e. if you have a cache (say ScalaCache) that you wrap & pass in to the fetch run, that cache can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant