Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Diff contains packaging script info as changes #38

Closed
kasperg opened this issue Dec 10, 2014 · 3 comments
Closed

Diff contains packaging script info as changes #38

kasperg opened this issue Dec 10, 2014 · 3 comments

Comments

@kasperg
Copy link
Contributor

kasperg commented Dec 10, 2014

When given the project, wayf_dk_login version 7.x-1.0, and a YML file of changes then the following actions will produce a patch with changes to wayf_dk_login.info which are not valid.

  1. Remove the second patch from the YML file
  2. Run bandaid-diff on the module
  3. See that the diff contains changes to the info file
diff --git a/wayf_dk_login.info b/wayf_dk_login.info
index b6b4897..8ecd89c 100644
--- a/wayf_dk_login.info
+++ b/wayf_dk_login.info
@@ -6,3 +6,9 @@ dependencies[] = ctools
 dependencies[] = date
 dependencies[] = date_api
 configure = admin/config/people/wayf
+
+; Information added by  packaging script on 2013-11-18
+version = "7.x-1.0"
+core = "7.x"
+project = "wayf_dk_login"
+datestamp = "1384778606"
@xendk
Copy link
Owner

xendk commented Jan 26, 2015

Can't reproduce. Still an issue?

@kasperg
Copy link
Contributor Author

kasperg commented Jan 26, 2015

I can reproduce this using master.

@xendk xendk closed this as completed in af9b3d6 Jan 27, 2015
@xendk
Copy link
Owner

xendk commented Jan 27, 2015

I couldn't bandaid-apply the yml file either, without it complaining about local changes.

Turn out that the info file, for the 1.0 release at least, contains "; Information added by packaging script on 2013-11-18", which is missing something.

Changed the regexp to take anything between "by " and " packaging".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants