Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alfresco integration can be confusing #98

Open
kerkhofsd opened this issue May 7, 2021 · 5 comments
Open

Alfresco integration can be confusing #98

kerkhofsd opened this issue May 7, 2021 · 5 comments

Comments

@kerkhofsd
Copy link
Contributor

kerkhofsd commented May 7, 2021

Since Alfresco Enterprise Edition 6.1, Alfresco records metrics using a Micrometer PrometheusMeterRegistry

As you can see in the docs, Alfred Telemetry integrates with this out of the box Alfresco metrics:
https://github.com/xenit-eu/alfred-telemetry/tree/master/alfred-telemetry-platform/docs#alfred-telemetry-alfresco-integration
Due to this integration, it is possible to 1) expose Alfresco metrics to monitoring systems configured in Alfred Telemetry and 2) expose Alfred Telemetry metrics in the default Alfresco Prometheus endpoint.

However in practice the integration can be quite confusing for administrators.
Should we entirely remove the integration of Alfred Telemetry with OOTB (Out Of The Box) Alfresco Micrometer metrics?

@todorinskiz
Copy link
Member

I don't see a reason to depend on external modules (OOTB) - Alfresco already provides MicroMeter metrics, so we should be exposing those IMO.
There is also no need to provide any compatibility features with OOTB:

  • Normally, all modules should use the same micrometer provided by the platform to avoid having multiple metrics registries
  • Publishing / exposing the metrics should be provided as a separate module, to avoid dependency problems and to avoid having to be aware of all of the possible metrics registered - we only care about what is registered inside MicroMeter, right?

This way both Alfred Telemetry and OOTB can run in parallel, without influencing each other.

@kerkhofsd
Copy link
Contributor Author

@todorinskiz OOTB = Out Of The Box. Sorry for the confusion.

@todorinskiz
Copy link
Member

In that case I would consider Alfresco as our central audience - let's expose our metrics to Alfresco by default.
This way we can make it easier for newcomers to start using it.

For other use cases that require reconfiguration for the monitoring system, seems reasonable to expect some learning curve there.

@todorinskiz
Copy link
Member

cc @tgeens @thijslemmens what do you think?

@kerkhofsd
Copy link
Contributor Author

Better option is to remove complexity and just remove integration between OOTBox Alfresco metrics and Alfred Telemetry. Not try to magically integrate them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants