Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to disable modifying log4j.properties #201

Closed
thijslemmens opened this issue Apr 2, 2021 · 1 comment · Fixed by #220
Closed

Make it possible to disable modifying log4j.properties #201

thijslemmens opened this issue Apr 2, 2021 · 1 comment · Fixed by #220
Labels
enhancement New feature or request has-jira-ticket Corresponding ticket has been opened in the Xenit Jira for planning

Comments

@thijslemmens
Copy link
Contributor

I want to use the docker-alfresco plugin to publish a war. However, the plugin always creates a task to modify the log4j.properties:

This task serves to remove the File appender and to prefix logs with [ALFRESCO] or [SHARE]. This is mainly useful in Docker scenario's. It would be nice to have a flag not to create the task.

@vierbergenlars vierbergenlars added enhancement New feature or request has-jira-ticket Corresponding ticket has been opened in the Xenit Jira for planning labels Jun 21, 2021
@vierbergenlars
Copy link
Member

While working on this, I discovered that rewriting log4j.properties in docker images is broken since a24e6dd (released in 5.0.7), where it was moved to a separate task.

However, it is still being rewritten in Alfresco WARs that are also created by the plugin.

I have heard no complaints about that from anywhere about this. So maybe we can just scrap the feature completely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request has-jira-ticket Corresponding ticket has been opened in the Xenit Jira for planning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants