Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No ability to force the output file format #258

Open
nevmerzhitsky opened this issue Aug 24, 2024 · 0 comments · May be fixed by #259
Open

[BUG] No ability to force the output file format #258

nevmerzhitsky opened this issue Aug 24, 2024 · 0 comments · May be fixed by #259
Labels
bug Something isn't working

Comments

@nevmerzhitsky
Copy link

nevmerzhitsky commented Aug 24, 2024

Basic information

  • Program version: 0.2.8
  • Python version: 3.11.9
  • Operating system: Linux/Windows

Describe the bug

There is no way to force the output file format. Therefore, the library understands the format wrong if the output file path doesn't match the predefined extension mask.

This makes it impossible to use the library in a context where a programmer cannot control the output path value (it's generated by a third party).

Command/Code used

  1. The command used (including the verbose tag, -v):
chat_downloader -v --output ./test.jsonl-temp-suffix URL

Expected behavior

A parameter like --output_format must exist.

Additional context/information

The ContinuousWriter class already supports this functionality, but the library doesn't expose it for clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant