test_ip, test_biosdevname_ns: Add typing stub, cleanup import & print

Add typing stub for pytest_forked, cleanup import; print() -> assert

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>

Author: bernhardkaindl

stubs/pytest_forked.pyi

@@ -0,0 +1,6 @@
+def serialize_report(rep): ...
+def pytest_addoption(parser) -> None: ...
+def pytest_load_initial_conftests(early_config, parser, args) -> None: ...
+def pytest_runtest_protocol(item): ...
+def forked_run_report(item): ...
+def report_process_crash(item, result): ...

tests/test_biosdevname_ns.py

@@ -2,8 +2,8 @@
 import unittest
 from os import system
 
-import pytest  # type: ignore # for pyre in tox only
-import pytest_forked  # type: ignore # pylint: disable=unused-import # This needs pytest-forked
+import pytest
+import pytest_forked  # pylint: disable=unused-import # Ensure pytest-forked is installed
 
 import xcp.net.biosdevname
 
@@ -12,11 +12,11 @@
 
 def check_devices(self, devices):
     for item in devices.items():
-        print(item[0])
-        print(item[1]["BIOS device"])
-        print(item[1]["Assigned MAC"])
-        print(item[1]["Bus Info"])
-        print(item[1]["Driver"])
+        assert item[0]
+        assert item[1]["BIOS device"]
+        assert item[1]["Assigned MAC"]
+        assert item[1]["Bus Info"]
+        assert item[1]["Driver"]
 
 
 class TestDeviceNames(unittest.TestCase):

tests/test_ip.py

@@ -4,8 +4,8 @@
 import unittest
 from subprocess import PIPE
 
-import pytest  # type: ignore # for pyre in tox only
-import pytest_forked  # type: ignore # pylint: disable=unused-import # This needs pytest-forked
+import pytest
+import pytest_forked  # pylint: disable=unused-import # Ensure pytest-forked is installed
 from mock import Mock, patch
 
 import xcp.net.ip