Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Twig coding standards #408

Closed
JakubSzajna opened this issue Jan 4, 2019 · 5 comments
Closed

Add note about Twig coding standards #408

JakubSzajna opened this issue Jan 4, 2019 · 5 comments
Assignees

Comments

@JakubSzajna
Copy link
Contributor

Hey,

I think there should be a link in the docs to the Twig Coding Standards as I can see some people do not follow them.
https://twig.symfony.com/doc/2.x/coding_standards.html

I was looking for some JS Twig linter, but apparently, there isn't any or I could not find one :(
There is a composer linter that requires PHP 7.1, has some other dependencies and is written for PHP's composer, so not sure if we want to go this way.

@marcinkrzeminski
Copy link
Collaborator

marcinkrzeminski commented Jan 4, 2019

Since PHP 5.x is dead I guess the PHP version is not an issue I guess. The composer factor might be a blocker here, however, if we decide to include composer in our stack we could start including other linters like phpcs and maybe ditch the bundled wp-cli and install plugins via composer.

What we could also do is to suggest using PHP Storm :) which has pretty good support in formatting for both Twig and WordPress.

@JakubSzajna
Copy link
Contributor Author

We've been there with a composer and if I remember well it wasn't so good. But I do not remember why ;) And correct me if I'm wrong, but the support for plugins in repositories is really bad or there isn't any.

And I doubt people would pay for PHPStorm if they do not use it already as there are really good free alternatives for it.

@marcinkrzeminski
Copy link
Collaborator

As of the plugins we have this: https://github.com/wp-premium, not sure if it covers all the plugins we use.

What are good free alternatives for PHP Storm? I've tried Sublime and VS Code and there is always something that is missing and makes me come back to PHP Storm ;/.

@luboskmetko
Copy link
Member

I'll add link to Twig standards to the documentation.

Regarding Twig linter, not sure if it's worth to add a new dependency just for that. Also in Chisel linting CSS/JS files works together with Prettier - so you don't have to care about formatting. Prettier for PHP is just alpha and there probably won't be any for Twig anytime soon.

As for composer there were various issues with it, for example #111

@luboskmetko luboskmetko changed the title Twig coding standards Add note about Twig coding standards Jan 8, 2019
@luboskmetko
Copy link
Member

Added note here https://www.getchisel.co/docs/development/twig/. I'm closing this but we can get back to this idea once there are better tools available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants