Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: team cards #626

Merged
merged 4 commits into from
Nov 28, 2022
Merged

fix: team cards #626

merged 4 commits into from
Nov 28, 2022

Conversation

patricia-mdias
Copy link
Contributor

@patricia-mdias patricia-mdias commented Nov 23, 2022 •
edited
Loading

Fixes #623

Screenshots (if visual changes)

6AA9F072-E5C1-4903-A2E8-D9228888BB8F

FDDB9D14-EC5E-41F5-AEB7-3AC68C4406C8

Proposed Changes

  • The teams list page should allow 3 avatars on the Team Admins.
  • On the team admin view, the "New Joiner" slider should have the same alignment as the "New Joiner" tooltip on the members view.

@CatiaAntunes96

This pull request closes #623

@patricia-mdias patricia-mdias added bug Something isn't working frontend labels Nov 23, 2022
@patricia-mdias patricia-mdias added this to the Full Version milestone Nov 23, 2022
@patricia-mdias patricia-mdias changed the title Bug/fix team cards [BUG]: Fix team cards #623 Nov 23, 2022
@patricia-mdias patricia-mdias changed the title [BUG]: Fix team cards #623 [BUG]: Fix team cards Nov 23, 2022
@patricia-mdias patricia-mdias changed the title [BUG]: Fix team cards Fix: team cards Nov 23, 2022
@patricia-mdias patricia-mdias changed the title Fix: team cards fix: team cards Nov 23, 2022
nunocaseiro
nunocaseiro previously approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

nunocaseiro
nunocaseiro approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@patricia-mdias patricia-mdias merged commit c96ed24 into main Nov 28, 2022
@patricia-mdias patricia-mdias deleted the bug/fix-team-cards branch November 28, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro Awaiting requested review from nunocaseiro

Assignees

@CatiaAntunes96 CatiaAntunes96

@patricia-mdias patricia-mdias

Labels
bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
SPLIT • Frontend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[BUG]: Fix team cards
3 participants
@patricia-mdias @nunocaseiro @CatiaAntunes96