Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up draw_xgi_nodes and draw_xgi_hyperedges #174

Closed
nwlandry opened this issue Sep 21, 2022 · 5 comments · Fixed by #456
Closed

Speed up draw_xgi_nodes and draw_xgi_hyperedges #174

nwlandry opened this issue Sep 21, 2022 · 5 comments · Fixed by #456
Labels
good first issue Good for newcomers improve Make an existing feature better viz

Comments

@nwlandry
Copy link
Collaborator

If we remove the for-loop in the function that draws the hypergraph nodes with scatter and instead pass iterables into the scatter function, it could be faster. Also, if we plot Collection objects instead of Patch objects, maybe it will be faster as well. (https://stackoverflow.com/questions/37573314/matplotlib-efficient-way-to-create-large-number-of-patch-objects)

@nwlandry nwlandry added the improve Make an existing feature better label Sep 21, 2022
@nwlandry
Copy link
Collaborator Author

@maximelucas
Copy link
Collaborator

Node speed-up implemented in #211

@maximelucas maximelucas added the good first issue Good for newcomers label May 12, 2023
@leotrs
Copy link
Collaborator

leotrs commented Jun 19, 2023

Any ideas on how to optimize the edge function?

@maximelucas
Copy link
Collaborator

I have a vague memory that it was supposed to be similar to the node speed-up, and that it was just that nobody implemented it. @nwlandry @iaciac ?

@nwlandry
Copy link
Collaborator Author

I tried to make it faster but my recollection was that plotting a collection of patches gave you less control over the color and other properties of individual edges compared with plotting a patch at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improve Make an existing feature better viz
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants