Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should draw with convex hull be the default and only behavior? #509

Open
nwlandry opened this issue Feb 13, 2024 · 6 comments
Open

Should draw with convex hull be the default and only behavior? #509

nwlandry opened this issue Feb 13, 2024 · 6 comments
Labels

Comments

@nwlandry
Copy link
Collaborator

With PR #491, drawing edges as convex hulls is now an option of draw. I'm wondering, however, if there is a case where we don't want this behavior. I'm specifically thinking of Issue #466, which occurs because the default behavior does NOT create convex hulls for edges. We could achieve roughly the same look by setting the default radius of the edges to 0.

@nwlandry
Copy link
Collaborator Author

nwlandry commented Apr 3, 2024

@thomasrobiglio --- any input on this? I know that you wrote the code for the hypergraph hull.

@thomasrobiglio
Copy link
Collaborator

I will have a look and get back to you on this!

@thomasrobiglio
Copy link
Collaborator

If I understand correctly this would make the default drawing style the rightmost plot in this screenshot, right?

Screenshot 2024-04-04 alle 10 15 13

I don't have a strong opinion on this. In this case of the sunflower hypergraph the new default would solve the issue, but in the general case with this choice we would remove one option for the personalization of plots.

@nwlandry
Copy link
Collaborator Author

nwlandry commented Apr 4, 2024

Thanks for the input! Yes, the left-most plot is what I was thinking for the default behavior. I'll make it an item of discussion for our next meeting!

@maximelucas
Copy link
Collaborator

The left plot is the current default, and you're suggesting to set the right one as the new default, right?

I agree with Thomas on this:

In this case of the sunflower hypergraph the new default would solve the issue, but in the general case with this choice we would remove one option for the personalization of plots.

This is a rather specific example, and I wouldn't change the default to drawing hulls just for that one. Were you thinking it would be good as a new default in other cases too?

@nwlandry
Copy link
Collaborator Author

nwlandry commented Apr 9, 2024

These are good points, but the issue is not restricted to sunflower hypergraphs. It occurs for any edge if it is large enough (A single edge of size $s\geq 12$ can reproduce this behavior). So maybe my question is whether it makes sense to allow users to draw non-convex edges. Of course, it doesn't matter if we are only drawing edges of sizes 2, 3, and 4 since those edges will be convex anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants