-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should draw with convex hull be the default and only behavior? #509
Comments
@thomasrobiglio --- any input on this? I know that you wrote the code for the hypergraph hull. |
I will have a look and get back to you on this! |
Thanks for the input! Yes, the left-most plot is what I was thinking for the default behavior. I'll make it an item of discussion for our next meeting! |
The left plot is the current default, and you're suggesting to set the right one as the new default, right? I agree with Thomas on this:
This is a rather specific example, and I wouldn't change the default to drawing hulls just for that one. Were you thinking it would be good as a new default in other cases too? |
These are good points, but the issue is not restricted to sunflower hypergraphs. It occurs for any edge if it is large enough (A single edge of size |
With PR #491, drawing edges as convex hulls is now an option of
draw
. I'm wondering, however, if there is a case where we don't want this behavior. I'm specifically thinking of Issue #466, which occurs because the default behavior does NOT create convex hulls for edges. We could achieve roughly the same look by setting the default radius of the edges to 0.The text was updated successfully, but these errors were encountered: