Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupingChooserModel.dimensions should be settable/updatable #2238

Closed
febbraiod opened this issue Dec 21, 2020 · 3 comments · Fixed by #3743
Closed

GroupingChooserModel.dimensions should be settable/updatable #2238

febbraiod opened this issue Dec 21, 2020 · 3 comments · Fixed by #3743
Assignees
Milestone

Comments

@febbraiod
Copy link
Member

No description provided.

@amcclain amcclain added the data label Apr 14, 2021
@amcclain amcclain changed the title Grouping chooser should allow for dynamically set dimensions GroupingChooserModel.dimensions should be settable/updatable Apr 14, 2021
@amcclain
Copy link
Member

Adding to backlog - if there is any extra priority or push from a client around this pls give a shout.

@amcclain amcclain added this to the Backlog milestone Jun 23, 2021
@febbraiod
Copy link
Member Author

No push or priority. I'm just using a less desirable component to achieve my ends. The client has no problem with what they have now.

@amcclain amcclain changed the title GroupingChooserModel.dimensions should be settable/updatable GroupingChooserModel.dimensions should be settable/updatable Jun 11, 2024
@amcclain amcclain added the ready label Jun 11, 2024
@amcclain amcclain removed this from the Backlog milestone Jun 11, 2024
@haynesjm42 haynesjm42 added this to the Quick Wins milestone Jun 28, 2024
@amcclain
Copy link
Member

One thing to check here is to ensure that the model handles things reasonably in the case where it already has a current value (a list of selected dimensions to group on) and then a new set of available dimensions is set via this new API. If the current value includes a dimension that is no longer supported, we need to modify it.

We could either clear out the value entirely, or we could strip out only dimensions that are no longer supported. I.e. a groupingChooserModel with value [portfolio, strategy, trader] would have its value automatically reset to [portfolio, trader] if a caller set groupingChooserModel.dimensions = [portfolio, trader, country]

@Ryanseanlee Ryanseanlee linked a pull request Jul 31, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants