Set vatcode and minor CS fixes

Author: Petteri Hakala

library/Xi/Netvisor/Resource/Xml/SalesInvoiceProductLine.php

@@ -7,10 +7,12 @@
 
 class SalesInvoiceProductLine
 {
-    const PRODUCT_IDENTIFIER_TYPE_CUSTOMER = 'customer';
-    const PRODUCT_IDENTIFIER_TYPE_NETVISOR = 'netvisor';
-    const UNIT_PRICE_TYPE_WITH_VAT = 'gross';
-    const UNIT_PRICE_TYPE_WITHOUT_VAT = 'net';
+    public const PRODUCT_IDENTIFIER_TYPE_CUSTOMER = 'customer';
+    public const PRODUCT_IDENTIFIER_TYPE_NETVISOR = 'netvisor';
+    public const UNIT_PRICE_TYPE_WITH_VAT = 'gross';
+    public const UNIT_PRICE_TYPE_WITHOUT_VAT = 'net';
+    public const VAT_CODE_KOMY = 'KOMY';
+    public const VAT_CODE_NONE = 'NONE';
 
     private $productIdentifier;
     private $productName;
@@ -50,7 +52,10 @@ public function __construct(
             $productUnitPrice, array('type' => self::UNIT_PRICE_TYPE_WITHOUT_VAT)
         );
 
-        $this->productVatPercentage = new AttributeElement($productVatPercentage, array('vatcode' => 'KOMY')); // TODO: different values.
+        $this->productVatPercentage = new AttributeElement(
+            $productVatPercentage, array('vatcode' => static::VAT_CODE_KOMY)
+        );
+
         $this->salesInvoiceProductLineQuantity = $salesInvoiceProductLineQuantity;
     }
 
@@ -66,8 +71,7 @@ public function addDimension($name, $item)
     }
 
     /**
-     * @param string $name
-     * @param string $item
+     * @param string $type
      * @return self
      */
     public function setProductIdentiefierType($type)
@@ -77,8 +81,7 @@ public function setProductIdentiefierType($type)
     }
 
     /**
-     * @param string $name
-     * @param string $item
+     * @param string $type
      * @return self
      */
     public function setUnitPriceType($type)
@@ -106,4 +109,14 @@ public function setAccountingAccount($account)
         $this->accountingaccountsuggestion = $account;
         return $this;
     }
+
+    /**
+     * @param string $code
+     * @return self
+     */
+    public function setVatCode($code)
+    {
+        $this->productVatPercentage->setAttribute('vatcode', $code);
+        return $this;
+    }
 }

tests/Xi/Netvisor/Resource/Xml/SalesInvoiceProductLineTest.php

@@ -142,4 +142,36 @@ public function testSetAccountingAccount()
 
         $this->assertXmlContainsTagWithValue('accountingaccountsuggestion', $account, $xml);
     }
+
+    /**
+     * @dataProvider setVatCodeProvider
+     */
+    public function testSetVatCode($code)
+    {
+        // Default
+        $xml = $this->toXml($this->invoiceProductLine);
+        $this->assertXmlContainsTagWithAttributes(
+            'productvatpercentage',
+            array('vatcode' => SalesInvoiceProductLine::VAT_CODE_KOMY),
+            $xml
+        );
+
+        // Setted value
+        $this->invoiceProductLine->setVatCode($code);
+        $xml = $this->toXml($this->invoiceProductLine);
+
+        $this->assertXmlContainsTagWithAttributes(
+            'productvatpercentage',
+            array('vatcode' => $code),
+            $xml
+        );
+    }
+
+    public function setVatCodeProvider()
+    {
+        return [
+            [SalesInvoiceProductLine::VAT_CODE_KOMY],
+            [SalesInvoiceProductLine::VAT_CODE_NONE],
+        ];
+    }
 }