New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check error on gzipWriter.Close() #3

Open

lunemec opened this issue May 14, 2019 · 0 comments

lunemec commented May 14, 2019

There is no error checking here https://github.com/xi2/httpgzip/blob/master/httpgzip.go#L399

I think the error should be handled, as it can lead to slient failures like this: golang/go#14975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment