-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complex problems #122
Comments
@wo80 Do you mind creating a minimal pull request reverting the problematic part? Then users like from upstream SciPy can confirm it fixes their issues and upvote the change. |
Considering the history of failed attempts to contribute, yes, I do mind. So you do the fix, please. And just to make this clear: merging #116 did break backwards compatibility, but that is actually the right way to proceed and it's not @xiaoyeli s responsibility to provide a backward compatible This obviously requires a major version bump and the release notes should be clear about breaking changes. |
Just wanted to make clear that this is NOT my proposal. Incompatible API changes => major version update. |
I do need to put up a release. But I don't think it's a major version, i.e., people can still use 'complex'. |
I released a new version 7.0.0 |
This
90ee45d#diff-862af30d14f5c76994c21cdb32acbba6da4cb1cd82f26144e417042f742608b2
completely defeats the purpose of #116
Please revert. It doesn't make any sense to have
#define complex singlecomplex
for "backward compatibility". There is no more use ofcomplex
anywhere in the SuperLU code since the PR was merged.The text was updated successfully, but these errors were encountered: