Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window maximization still doesn't work #1016

Closed
atauzki opened this issue Jul 27, 2023 · 10 comments · Fixed by #1019
Closed

Window maximization still doesn't work #1016

atauzki opened this issue Jul 27, 2023 · 10 comments · Fixed by #1019
Assignees
Labels

Comments

@atauzki
Copy link
Collaborator

atauzki commented Jul 27, 2023

win11,pull最新版本(commit id:3283a58)清除缓存重新编译后,运行窗口最大化,再退出重新启动,窗口仍然无法自动最大化

@github-actions
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically.

Win11, after pulling the latest version to clear the cache and recompile, the running window still cannot be automatically maximized

@github-actions github-actions bot changed the title 窗口最大化仍无效 Window maximization still doesn't work Jul 27, 2023
@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Jul 27, 2023

据观察在一瞬间会最大化,应该是这个 bug, https://bugreports.qt.io/browse/QTBUG-115074

我复制 bug 里面的代码,可以在 Windows 上稳定复现,存在 QWebEngineView 的情况下,showMaxmized 直接用不了,只会全屏闪一下 😅

SAD.mp4

@github-actions
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically.

It is observed that it will be maximized in an instant, it should be this bug, https://bugreports.qt.io/browse/QTBUG-115074

I copied the code in the bug, and it can be reproduced stably on Windows. In the case of QWebEngineView, showMaximized cannot be used directly 😅

SAD.mp4

@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Jul 27, 2023

我觉得 #1013 可能需要 revert 掉,这是 Qt 本体的 bug

@github-actions
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically.

I think #1013 needs to be reverted, this is a bug in the Qt body

@xiaoyifang
Copy link
Owner

我觉得 #1013 可能需要 revert 掉,这是 Qt 本体的 bug

reverted

@github-actions
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically.

I think #1013 may need to be reverted, this is a bug in the Qt body

reversed

@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Jul 27, 2023

这个 bug 的触发条件是网页没有加载任何内容前 showMaxmized 直接不能用

那把 restoreState restoreGeometry

if ( cfg.mainWindowState.size() && !cfg.resetState )
restoreState( cfg.mainWindowState );
if ( cfg.mainWindowGeometry.size() )
restoreGeometry( cfg.mainWindowGeometry );

移动到 加载完 "Welcome" 的 下面 就可以了 😅

view->showDefinition( tr( "Welcome!" ), Instances::Group::HelpGroupId );

image

Repository owner deleted a comment from github-actions bot Jul 27, 2023
@xiaoyifang
Copy link
Owner

移动到 加载完 "Welcome" 的 下面 就可以了 😅

you can make a PR .

@github-actions
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically.

Move to the bottom of "Welcome" after loading and that's it 😅

you can make a PR .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants