-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window maximization still doesn't work #1016
Comments
Win11, after pulling the latest version to clear the cache and recompile, the running window still cannot be automatically maximized |
据观察在一瞬间会最大化,应该是这个 bug, https://bugreports.qt.io/browse/QTBUG-115074 我复制 bug 里面的代码,可以在 Windows 上稳定复现,存在 QWebEngineView 的情况下,showMaxmized 直接用不了,只会全屏闪一下 😅 SAD.mp4 |
It is observed that it will be maximized in an instant, it should be this bug, https://bugreports.qt.io/browse/QTBUG-115074 I copied the code in the bug, and it can be reproduced stably on Windows. In the case of QWebEngineView, showMaximized cannot be used directly 😅 SAD.mp4 |
我觉得 #1013 可能需要 revert 掉,这是 Qt 本体的 bug |
I think #1013 needs to be reverted, this is a bug in the Qt body |
reverted |
reversed |
这个 bug 的触发条件是网页没有加载任何内容前 showMaxmized 直接不能用 那把 restoreState restoreGeometry goldendict-ng/src/ui/mainwindow.cc Lines 744 to 747 in 69905ed
移动到 加载完 "Welcome" 的 下面 就可以了 😅 goldendict-ng/src/ui/mainwindow.cc Line 773 in 69905ed
|
you can make a PR . |
you can make a PR . |
win11,pull最新版本(commit id:3283a58)清除缓存重新编译后,运行窗口最大化,再退出重新启动,窗口仍然无法自动最大化
The text was updated successfully, but these errors were encountered: