Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibility to use libzim to parse the zim dictionary #30

Closed
xiaoyifang opened this issue Mar 21, 2022 · 4 comments
Closed

possibility to use libzim to parse the zim dictionary #30

xiaoyifang opened this issue Mar 21, 2022 · 4 comments
Labels
good first issue Good for newcomers Need More Info Need More Info

Comments

@xiaoyifang
Copy link
Owner

Actually, they explicitly changed from GPL2 to GPL2+

openzim/libzim@f57bca2

Plus this chart from gnu.org

https://www.gnu.org/licenses/gpl-faq.en.html#AllCompatibility

their previous discussion on this matter

openzim/libzim#30

Originally posted by @shenlebantongying in #27 (comment)

@xiaoyifang
Copy link
Owner Author

xiaoyifang commented Mar 21, 2022

the cons and pros of using libzim,
pros:

cons:

  • the gd has built-in fulltext support ,which means zim dictionary will use its own fulltext function ,inconsistence?
  • kiwix is already out there with better zim support .

ideas and commits are welcome .

@ancientstraits
Copy link

Sure, I could contribute to this. Would zim.cc be the only file I would have to change?

@xiaoyifang
Copy link
Owner Author

great, AFAIK ,zim.cc is the file.

@xiaoyifang
Copy link
Owner Author

xiaoyifang commented Mar 22, 2022

add some test data:
goldendict: wikipedia_zh_all_maxi_2022-01.zim 19G ,parse with gd about 20 seconds and search is ok.

the test data is not bad ,before we use libzim ,maybe we should investigate the performance first @ancientstraits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Need More Info Need More Info
Projects
None yet
Development

No branches or pull requests

2 participants