Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media (URL): Validation needed for unsupported URLs like YouTube #3514

Closed
maurofmferrao opened this issue Sep 30, 2024 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@maurofmferrao
Copy link
Member

When adding a YouTube link via the Add Media (URL) form, an Unexpected Error, please contact support. message appears. This happens because YouTube URLs are not supported as media, leading to a null value being passed in Library.php on line 2526.

Xibo\Factory\ModuleFactory::getByExtension(): Argument #1 ($extension) must be of type string, null given, called in /var/www/cms/lib/Controller/Library.php on line 2526

Steps to reproduce:

  • Attempt to add a YouTube URL in the Add Media (URL) form.
  • Observe the error message in log

Proposed solution:

  • Add Validation: Prevent unsupported URLs (like YouTube) from being submitted in the form.
  • Clearer Error Message: Display a specific message when an unsupported media type is added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants