Skip to content
This repository has been archived by the owner on May 19, 2022. It is now read-only.

sockets for redirections are not using any security #30

Closed
xilun opened this issue Aug 15, 2016 · 6 comments
Closed

sockets for redirections are not using any security #30

xilun opened this issue Aug 15, 2016 · 6 comments
Assignees

Comments

@xilun
Copy link
Owner

xilun commented Aug 15, 2016

So there is still a risk when used on a multi user computer for now...

@xilun
Copy link
Owner Author

xilun commented Aug 15, 2016

One way to fix that would be to also connect from the client to outbash.exe for redirection sockets (and not what is done for now in v0.9 and current HEAD: the reverse direction)

  • advantage: same security code as for control socket
  • drawback: "slow" when using lots of TCP socket on the same computer - but I can limit to a single extra call to GetExtendedTcpTable, or maybe even still only one per process spawn

Or I could implement custom security inband for redirection sockets -- but I'd rather not.

@xilun
Copy link
Owner Author

xilun commented Aug 15, 2016

Or the client could wait for a confirmation of outbash.exe before starting redirection forwarding. outbash.exe would not confirm before successful connection to redirection port. (Each redirection port is exclusively owned by the client.)

@xilun xilun self-assigned this Aug 15, 2016
@xilun
Copy link
Owner Author

xilun commented Aug 17, 2016

3cfe57d partially mitigates the risk for now.

Further commits will eliminate it -- they will probably be backward incompatible at protocol level.

@xilun
Copy link
Owner Author

xilun commented Aug 18, 2016

b4a8cf4 does not change the situation for now, but prepare for further changes that will.

@xilun
Copy link
Owner Author

xilun commented Aug 20, 2016

5383b61 finishes to fix this issue. A new release will be published soon.

@xilun
Copy link
Owner Author

xilun commented Aug 20, 2016

Fixed in release v0.10

@xilun xilun closed this as completed Aug 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant