Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sepc for <screenshot> environment style not clear #667

Open
sophie-h opened this issue Sep 22, 2024 · 1 comment
Open

Sepc for <screenshot> environment style not clear #667

sophie-h opened this issue Sep 22, 2024 · 1 comment

Comments

@sophie-h
Copy link

The spec defines that the environment has to be

in the form of {env}:{style},

but also contains an example of the form

<screenshot environment="plasma-mobile">

which seems contractory.

Additionally, since the XDG standard for org.freedesktop.appearance color-scheme not only knows "dark" and "light," but also "No preference." I think it would make sense to also suggest a for "No preference" like :default or omitting the style as in plasma-mobile.

@bbhtt
Copy link

bbhtt commented Nov 5, 2024

I think it would make sense to also suggest a for "No preference" like :default or omitting the style as in plasma-mobile.

Considering that the environment key is tied to the validation already I think it's better to have the existing :style -less value to mean "no-preference" and modify the spec to allow this.

Otherwise enforcing a :default means everyone's metainfo will start failing validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants