Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process_frame() refactor broke 2-pass encoding #2208

Closed
rzumer opened this issue Mar 21, 2020 · 0 comments · Fixed by #2209
Closed

process_frame() refactor broke 2-pass encoding #2208

rzumer opened this issue Mar 21, 2020 · 0 comments · Fixed by #2209
Assignees
Labels

Comments

@rzumer
Copy link
Collaborator

rzumer commented Mar 21, 2020

45ef0af causes only one frame to be encoded in my 2-pass encoding tests (happens on the first pass, so could also occur for single-pass). After reverting this commit only, master works as expected.

<derf> I mean, by the time you're at Result<Option<Vec<...>>, ...>, and all of different possibilities (Ok(None/Some(empty/full))/Err) have different meanings for the caller, maybe it is time to start thinking about an enum or something to tell people what is actually going on.
<derf> That patch collapsed two of the meanings (None and an empty Vec), but didn't actually preserve the existing code's behavior in those cases.
@rzumer rzumer added the bug label Mar 21, 2020
@rzumer rzumer changed the title process_fame refactor broke 2-pass encoding process_frame() refactor broke 2-pass encoding Mar 21, 2020
@shssoichiro shssoichiro self-assigned this Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants