Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task explanations that have been saved to tasks.dat don't get translated after language change #256

Open
GoogleCodeExporter opened this issue Feb 2, 2016 · 1 comment

Comments

@GoogleCodeExporter
Copy link

This is probably one for the "WontFix" category, 
but I'm reporting it in case somebody sees an easy 
way to fix it.

Task descriptions get translated when the task is 
created, and then saved to tasks.dat. When the user 
switches languages, these descriptions won't get 
translated. They can't be easily translated in that 
state either because the variables have already 
been replaced with their actual values.

A fix would be to save the explanation in 
translatable English format (i.e. with variables 
like %s and %i still intact), save the values of 
these variables afterwards, and then construct and 
translate the string when the task board is loaded.

However, the problem only occurs if the player 
changes languages mid-game (which shouldn't happen 
very often), and only affects messages that have 
been written with a different language selection 
than the current one (subsequent tasks will be 
translated upon creation and thus be displayed in 
the desired language, unless the language gets 
changed again). So spending a lot of effort to fix 
this might not be worth it.

Original issue reported on code.google.com by Psyyri...@gmail.com on 16 Dec 2009 at 9:15

@GoogleCodeExporter
Copy link
Author

i wonder why we couldn't just have the whole file parsed and rewritten when 
languages are changed....run the whole file through the translator.

Original comment by omegabla...@gmail.com on 17 Apr 2011 at 7:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant