-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor]: config #604
Comments
i want to try it |
Due to my personal time constraints, I abandon this issue. I am very sorry. |
Hey @themanforfree , since caicancai is not working on this issue, i would like to try it out! |
This issue has been assigned to you, thank you for your contribution |
Hi, I would like to take a look at this issue. Refactoring seems like a good starting to get to understand the codebase. |
@qstommyshu ,Harsh1s has initiate a pull request to solve this issue,can you try another good-first-issue? Thanks 😄 |
Now all of our configurations are in a single file,
utils/src/config.rs
,It also contains a lot ofparse_xxx
,xxx_format
,default_xxx
methods, It's messy and difficult to manage. We need to organize these configurations into modules, each containing the configuration itself, its parse method, and default values.In addition, the configuration can only be created through the new method, which is very inflexible, we need to refactor them use builder pattern, and it should be easy to modify existing configurations
The text was updated successfully, but these errors were encountered: