Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change struct #39

Closed
kristinapathak opened this issue Nov 6, 2019 · 0 comments · Fixed by #42
Closed

Change struct #39

kristinapathak opened this issue Nov 6, 2019 · 0 comments · Fixed by #42
Labels
enhancement New feature or request

Comments

@kristinapathak
Copy link
Contributor

Change struct tags from wrp to json so that a Marshal() or Unmarshal() using the standard json library would be compatible.

One example of the structs is the wrp.Message struct:

type Message struct {

The below lines need to be changed so that when parsing the wrp, we look for the json tag rather than the wrp tag.

TypeInfos: codec.NewTypeInfos([]string{"wrp"}),

TypeInfos: codec.NewTypeInfos([]string{"wrp"}),

this is related to this issue: xmidt-org/scytale#70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant