Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When creating an internal DTD, external cannot be nil #215

Open
slimdave opened this issue Sep 27, 2024 · 4 comments
Open

When creating an internal DTD, external cannot be nil #215

slimdave opened this issue Sep 27, 2024 · 4 comments

Comments

@slimdave
Copy link

In f82dfd2 looks like external, system, and name were made non-nullable.

That was reverted for name in 2852b92

But it seems that it's not now possible to produce an internal DTD, because external cannot be nil?
@cfis
Copy link
Member

cfis commented Sep 29, 2024

Sorry, not following. What would you like to change?

@slimdave
Copy link
Author

Can nil be passed for the value of external in the initializer for ext/libxml/ruby_xml_dtd.c?

@cfis
Copy link
Member

cfis commented Oct 1, 2024

Ah. Ok looks like no, it has to be set. Want to create a PR?

@slimdave
Copy link
Author

slimdave commented Oct 4, 2024

I don't really know any C I'm afraid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cfis @slimdave