Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook Runner uses last release of python package rather than installing from source #785

Open
banoffee-pie opened this issue Jul 26, 2023 · 0 comments

Comments

@banoffee-pie
Copy link
Contributor

The Jenkins CI runs all the notebooks in /docs to make sure that they are updated (e.g. if any APIs change). However, notebooks using the xmos_ai_tools package install the module from PyPi. This means that the test will run against the latest python package release rather than the source code on the current PR.

This could result in a situation where an API of a module in xmos_ai_tools package is changed in a PR, but the CI incorrectly determines that the notebooks still work.

There should be a separate requirements file for CI that installs the ai_tools package built from the source code on that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant