Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message type 'direct' is non-standard #86

Open
3 tasks
michaelansel opened this issue Jul 16, 2015 · 2 comments
Open
3 tasks

Message type 'direct' is non-standard #86

michaelansel opened this issue Jul 16, 2015 · 2 comments
Labels
Milestone

Comments

@michaelansel
Copy link

As of OpenFire 3.10.2, messages with type 'direct' are considered invalid and any client attempting to send one is immediately disconnected. I can't figure out why this behavior changed (we upgraded from 3.8.2), but reading through the spec, a message with type 'direct' never should have worked in the first place. Instead, 1-to-1 messages should use the message type 'chat'.

  • Update documentation to always recommend message type 'chat'
  • Emit a warning if message type 'direct' (or any other invalid type) is used
  • Add a sendPrivateMessage function that abstracts away this weirdness

XMPP Message Types: http://xmpp.org/rfcs/rfc3921.html#stanzas-message-type

@michaelansel
Copy link
Author

I'll start working on patches as soon as I have a chance...

@markstory
Copy link
Contributor

Neat, I built the original code using ejabberd. Interesting that the two popular xmpp servers both implemented the nonstandard message type in the same way.

@markstory markstory added this to the 0.1.16 milestone Jul 16, 2015
@markstory markstory added the bug label Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants